Adding enable ultra ssd, eviction policy, and spot max price support for machine by erinborders · Pull Request #9696 · Azure/azure-cli-extensions

erinborders · 2026-03-17T15:41:52Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks machine add

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2026-03-17T15:41:57Z

❌Azure CLI Extensions Breaking Change Test

⚠️aks-preview

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd aks machine add cmd aks machine add added parameter enable_ultra_ssd

⚠️ 1006 - ParaAdd aks machine add cmd aks machine add added parameter eviction_policy

⚠️ 1006 - ParaAdd aks machine add cmd aks machine add added parameter spot_max_price

❌managedcleanroom

rule cmd_name rule_message suggest_message

❌ 1006 - ParaAdd managedcleanroom collaboration add-collaborator cmd managedcleanroom collaboration add-collaborator added parameter email please remove parameter email for cmd managedcleanroom collaboration add-collaborator

❌ 1007 - ParaRemove managedcleanroom collaboration add-collaborator cmd managedcleanroom collaboration add-collaborator removed parameter object_id please add back parameter object_id for cmd managedcleanroom collaboration add-collaborator

❌ 1007 - ParaRemove managedcleanroom collaboration add-collaborator cmd managedcleanroom collaboration add-collaborator removed parameter tenant_id please add back parameter tenant_id for cmd managedcleanroom collaboration add-collaborator

❌ 1007 - ParaRemove managedcleanroom collaboration add-collaborator cmd managedcleanroom collaboration add-collaborator removed parameter user_identifier please add back parameter user_identifier for cmd managedcleanroom collaboration add-collaborator

❌ 1006 - ParaAdd managedcleanroom collaboration create cmd managedcleanroom collaboration create added parameter consortium_type please remove parameter consortium_type for cmd managedcleanroom collaboration create

❌ 1006 - ParaAdd managedcleanroom collaboration create cmd managedcleanroom collaboration create added parameter user_identity please remove parameter user_identity for cmd managedcleanroom collaboration create

❌ 1007 - ParaRemove managedcleanroom collaboration create cmd managedcleanroom collaboration create removed parameter collaborators please add back parameter collaborators for cmd managedcleanroom collaboration create

⚠️ 1006 - ParaAdd managedcleanroom collaboration update cmd managedcleanroom collaboration update added parameter consortium_type

⚠️ 1006 - ParaAdd managedcleanroom collaboration update cmd managedcleanroom collaboration update added parameter user_identity

⚠️ 1006 - ParaAdd managedcleanroom consortium create cmd managedcleanroom consortium create added parameter consortium_type

⚠️ 1006 - ParaAdd managedcleanroom consortium update cmd managedcleanroom consortium update added parameter consortium_type

azure-client-tools-bot-prd · 2026-03-17T15:42:01Z

Hi @erinborders,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2026-03-17T15:43:34Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2026-03-17T15:43:38Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2026-03-17T15:47:49Z

Hi @erinborders

Release Suggestions

Module: aks-preview

Update VERSION to 19.0.0b29 in src/aks-preview/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

github-actions · 2026-03-17T15:49:06Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

FumingZhang · 2026-03-17T23:15:20Z

/azp run

azure-pipelines · 2026-03-17T23:15:36Z

Azure Pipelines successfully started running 2 pipeline(s).

src/aks-preview/azext_aks_preview/machine.py

FumingZhang

Could you add some unit tests? It would also be helpful to include a scenario test (e2e test) in test_aks_commands.py.

…borders/azure-cli-extensions into erinborders/machine-preview

FumingZhang · 2026-03-19T23:26:00Z

/azp run

azure-pipelines · 2026-03-19T23:26:16Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-03-19T23:26:18Z

fixing the linter error about az aks delete in #9703

FumingZhang · 2026-03-19T23:38:14Z

/azp run

azure-pipelines · 2026-03-19T23:38:27Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang

Queued live test to validate the change. Once test passed, please commit the recording file (find it from pipeline artifacts) to pass the CI check.

test_aks_machine_add_spot_and_ultra_ssd

FumingZhang · 2026-03-20T00:55:33Z

fixing the linter error about az aks delete in #9703

Please rebase from main to pick up the fix, cc @erinborders

The CI GH Azdev Linter / azdev-linter (pull_request_target) sets up the test environment based on your branch's HEAD, not the merge reference, so it won't automatically pick up the fix.

…sions into erinborders/machine-preview

FumingZhang · 2026-03-22T23:56:01Z

/azp run

azure-pipelines · 2026-03-22T23:56:17Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-03-23T02:27:47Z

Queued live test to validate the change. Once test passed, please commit the recording file (find it from pipeline artifacts) to pass the CI check.

test_aks_machine_add_spot_and_ultra_ssd

Re-queued live test

…sions into erinborders/machine-preview

FumingZhang · 2026-03-25T00:19:11Z

/azp run

azure-pipelines · 2026-03-25T00:19:23Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-03-25T01:06:53Z

Re-queued live test. Don't forget to commit the recording file after the live test has passed to ensure the CI checks are successful.

…sions into erinborders/machine-preview

FumingZhang · 2026-03-27T00:01:46Z

/azp run

azure-pipelines · 2026-03-27T00:01:59Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-03-27T02:52:42Z

src/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/models/_models_py3.py

    }

-    def __init__(self, *, properties: Optional["_models.MachineProperties"] = None, **kwargs: Any) -> None:
+    def __init__(self, *, properties: Optional["_models.MachineProperties"] = None, zones: Optional[List[str]] = None, **kwargs: Any) -> None:


It's unusual to manually update the generated SDK. If zones aren't meant to be read-only, this should be adjusted in the API specification; otherwise, the change will be overwritten the next time the SDK is generated.

FumingZhang · 2026-03-27T02:56:25Z

src/aks-preview/azext_aks_preview/machine.py

+        operation_group="machines"
+    )
+    machineBillingProfile = MachineBillingProfile(
+        spot_max_price=spot_max_price


the default value float("nan") is not standard in JSON

erinborders added 3 commits March 17, 2026 11:22

add spot max price flag

3752bec

enable ultra ssd and eviction policy

b787769

change notes

bf3be79

erinborders requested review from FumingZhang and andyliuliming as code owners March 17, 2026 15:41

Copilot AI review requested due to automatic review settings March 17, 2026 15:41

azure-client-tools-bot-prd bot added this to the April 2026 (2026-04-07) milestone Mar 17, 2026

microsoft-github-policy-service bot requested review from yanzhudd, yonzhan and zhoxing-ms March 17, 2026 15:42

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Mar 17, 2026

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS labels Mar 17, 2026

Copilot started reviewing on behalf of erinborders March 17, 2026 15:46 View session

erinborders added 2 commits March 17, 2026 11:52

linting

2be46ca

linting

ad7b35d

Copilot AI reviewed Mar 17, 2026

View reviewed changes

FumingZhang reviewed Mar 17, 2026

View reviewed changes

src/aks-preview/azext_aks_preview/machine.py Show resolved Hide resolved

FumingZhang reviewed Mar 17, 2026

View reviewed changes

yonzhan unassigned zhoxing-ms Mar 18, 2026

test coverage

72f4df4

Merge branch 'erinborders/machine-preview' of https://github.com/erin…

601acd9

…borders/azure-cli-extensions into erinborders/machine-preview

FumingZhang reviewed Mar 20, 2026

View reviewed changes

erinborders added 2 commits March 20, 2026 10:36

Merge branch 'main' of https://github.com/erinborders/azure-cli-exten…

4e6cd6d

…sions into erinborders/machine-preview

modify test

20fef2b

erinborders added 6 commits March 24, 2026 11:13

hardware property name

fb1bf72

Merge branch 'main' of https://github.com/erinborders/azure-cli-exten…

2bf4bd9

…sions into erinborders/machine-preview

add zones

799f29c

space

4d42dc5

nodepool zone

47806a9

multiple zones

5712645

erinborders added 5 commits March 25, 2026 17:25

typo

d7882ce

Merge branch 'main' of https://github.com/erinborders/azure-cli-exten…

1ab8a94

…sions into erinborders/machine-preview

fix silently discarded zones property

360a345

Merge branch 'main' of https://github.com/erinborders/azure-cli-exten…

e03e118

…sions into erinborders/machine-preview

key error

b3fdfb4

FumingZhang reviewed Mar 27, 2026

View reviewed changes

Conversation

erinborders commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Mar 17, 2026

Uh oh!

yonzhan commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Suggestions

Module: aks-preview

Notes

Uh oh!

github-actions bot commented Mar 17, 2026

CodeGen Tools Feedback Collection

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

FumingZhang commented Mar 17, 2026

Uh oh!

azure-pipelines bot commented Mar 17, 2026

Uh oh!

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

FumingZhang commented Mar 19, 2026

Uh oh!

azure-pipelines bot commented Mar 19, 2026

Uh oh!

FumingZhang commented Mar 19, 2026

Uh oh!

FumingZhang commented Mar 19, 2026

Uh oh!

azure-pipelines bot commented Mar 19, 2026

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

FumingZhang commented Mar 20, 2026

Uh oh!

FumingZhang commented Mar 22, 2026

Uh oh!

azure-pipelines bot commented Mar 22, 2026

Uh oh!

FumingZhang commented Mar 23, 2026

Uh oh!

FumingZhang commented Mar 25, 2026

Uh oh!

azure-pipelines bot commented Mar 25, 2026

Uh oh!

FumingZhang commented Mar 25, 2026

Uh oh!

FumingZhang commented Mar 27, 2026

Uh oh!

azure-pipelines bot commented Mar 27, 2026

Uh oh!

FumingZhang Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

FumingZhang Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

erinborders commented Mar 17, 2026 •

edited

Loading

azure-client-tools-bot-prd bot commented Mar 17, 2026 •

edited

Loading

github-actions bot commented Mar 17, 2026 •

edited

Loading