Skip to content

Enable Backup Command for AKS in dataprotection CLI#9701

Open
anshulahuja98 wants to merge 28 commits intoAzure:mainfrom
anshulahuja98:aksbackup
Open

Enable Backup Command for AKS in dataprotection CLI#9701
anshulahuja98 wants to merge 28 commits intoAzure:mainfrom
anshulahuja98:aksbackup

Conversation

@anshulahuja98
Copy link

@anshulahuja98 anshulahuja98 commented Mar 18, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

anshulahuja98 and others added 18 commits September 12, 2024 09:00
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
…dling

Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Copilot AI review requested due to automatic review settings March 18, 2026 09:02
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Mar 18, 2026

⚠️Azure CLI Extensions Breaking Change Test
⚠️dataprotection
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd dataprotection enable-backup sub group dataprotection enable-backup added

@azure-client-tools-bot-prd
Copy link

Hi @anshulahuja98,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 18, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
@anshulahuja98 anshulahuja98 marked this pull request as draft March 18, 2026 09:59
Anshul Ahuja added 2 commits March 19, 2026 10:36
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
@FumingZhang
Copy link
Member

fixing failed CI check about aks delete command in #9703

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

fixing failed CI check about aks delete command in #9703

Please rebase from main to pick up the fix, cc @anshulahuja98

The CI GH Azdev Linter / azdev-linter (pull_request_target) sets up the test environment based on your branch's HEAD, not the merge reference, so it won't automatically pick up the fix.

Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@anshulahuja98
Copy link
Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 9701 in repo Azure/azure-cli-extensions

@anshulahuja98 anshulahuja98 marked this pull request as ready for review March 23, 2026 04:52
@Miraj50
Copy link
Contributor

Miraj50 commented Mar 23, 2026

Reviewed the enable-backup business logic.

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
@anshulahuja98
Copy link
Author

Wait on final signoff from @zubairabid before merge.

Copy link
Contributor

@zubairabid zubairabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor documentation nit, otherwise this looks good.

Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang FumingZhang removed the AKS label Mar 24, 2026
@FumingZhang FumingZhang removed their request for review March 24, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants