Enable Backup Command for AKS in dataprotection CLI#9701
Enable Backup Command for AKS in dataprotection CLI#9701anshulahuja98 wants to merge 28 commits intoAzure:mainfrom
Conversation
…-preview extension
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
…dling Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| dataprotection enable-backup | sub group dataprotection enable-backup added |
|
Hi @anshulahuja98, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
|
fixing failed CI check about |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Please rebase from main to pick up the fix, cc @anshulahuja98 The CI |
src/dataprotection/azext_dataprotection/manual/aks/aks_helper.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9701 in repo Azure/azure-cli-extensions |
|
Reviewed the enable-backup business logic. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
|
Wait on final signoff from @zubairabid before merge. |
zubairabid
left a comment
There was a problem hiding this comment.
One minor documentation nit, otherwise this looks good.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.