Fix EMR Spark support by using Seq instead of ArrayBuffer for externa…#10987
Draft
aboitreaud wants to merge 1 commit intomasterfrom
Draft
Fix EMR Spark support by using Seq instead of ArrayBuffer for externa…#10987aboitreaud wants to merge 1 commit intomasterfrom
aboitreaud wants to merge 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~0cb068786f, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064739
Total [baseline] (11.063 s) : 0, 11062658
Agent [candidate] (1.056 s) : 0, 1056373
Total [candidate] (11.037 s) : 0, 11037017
section appsec
Agent [baseline] (1.249 s) : 0, 1248914
Total [baseline] (11.183 s) : 0, 11182584
Agent [candidate] (1.248 s) : 0, 1247867
Total [candidate] (11.251 s) : 0, 11250594
section iast
Agent [baseline] (1.236 s) : 0, 1236329
Total [baseline] (11.307 s) : 0, 11307439
Agent [candidate] (1.231 s) : 0, 1231445
Total [candidate] (11.347 s) : 0, 11346864
section profiling
Agent [baseline] (1.182 s) : 0, 1181789
Total [baseline] (11.132 s) : 0, 11131669
Agent [candidate] (1.182 s) : 0, 1182233
Total [candidate] (11.059 s) : 0, 11058791
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~0cb068786f, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (632.562 ms) : 0, 632562
BytebuddyAgent [candidate] (628.836 ms) : 0, 628836
AgentMeter [baseline] (29.627 ms) : 0, 29627
AgentMeter [candidate] (29.346 ms) : 0, 29346
GlobalTracer [baseline] (258.749 ms) : 0, 258749
GlobalTracer [candidate] (256.817 ms) : 0, 256817
AppSec [baseline] (31.955 ms) : 0, 31955
AppSec [candidate] (31.693 ms) : 0, 31693
Debugger [baseline] (60.661 ms) : 0, 60661
Debugger [candidate] (60.224 ms) : 0, 60224
Remote Config [baseline] (589.427 µs) : 0, 589
Remote Config [candidate] (616.855 µs) : 0, 617
Telemetry [baseline] (8.163 ms) : 0, 8163
Telemetry [candidate] (8.004 ms) : 0, 8004
Flare Poller [baseline] (5.05 ms) : 0, 5050
Flare Poller [candidate] (3.526 ms) : 0, 3526
section appsec
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (659.622 ms) : 0, 659622
BytebuddyAgent [candidate] (659.756 ms) : 0, 659756
AgentMeter [baseline] (12.136 ms) : 0, 12136
AgentMeter [candidate] (12.112 ms) : 0, 12112
GlobalTracer [baseline] (258.61 ms) : 0, 258610
GlobalTracer [candidate] (257.721 ms) : 0, 257721
IAST [baseline] (24.145 ms) : 0, 24145
IAST [candidate] (24.139 ms) : 0, 24139
AppSec [baseline] (177.997 ms) : 0, 177997
AppSec [candidate] (177.844 ms) : 0, 177844
Debugger [baseline] (66.41 ms) : 0, 66410
Debugger [candidate] (66.276 ms) : 0, 66276
Remote Config [baseline] (625.844 µs) : 0, 626
Remote Config [candidate] (632.979 µs) : 0, 633
Telemetry [baseline] (8.318 ms) : 0, 8318
Telemetry [candidate] (8.262 ms) : 0, 8262
Flare Poller [baseline] (3.553 ms) : 0, 3553
Flare Poller [candidate] (3.545 ms) : 0, 3545
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (802.701 ms) : 0, 802701
BytebuddyAgent [candidate] (798.898 ms) : 0, 798898
AgentMeter [baseline] (11.492 ms) : 0, 11492
AgentMeter [candidate] (11.443 ms) : 0, 11443
GlobalTracer [baseline] (248.53 ms) : 0, 248530
GlobalTracer [candidate] (248.063 ms) : 0, 248063
IAST [baseline] (25.527 ms) : 0, 25527
IAST [candidate] (25.404 ms) : 0, 25404
AppSec [baseline] (26.711 ms) : 0, 26711
AppSec [candidate] (26.687 ms) : 0, 26687
Debugger [baseline] (69.979 ms) : 0, 69979
Debugger [candidate] (70.622 ms) : 0, 70622
Remote Config [baseline] (531.548 µs) : 0, 532
Remote Config [candidate] (532.223 µs) : 0, 532
Telemetry [baseline] (9.716 ms) : 0, 9716
Telemetry [candidate] (9.113 ms) : 0, 9113
Flare Poller [baseline] (3.573 ms) : 0, 3573
Flare Poller [candidate] (3.316 ms) : 0, 3316
section profiling
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (682.397 ms) : 0, 682397
BytebuddyAgent [candidate] (682.625 ms) : 0, 682625
AgentMeter [baseline] (8.987 ms) : 0, 8987
AgentMeter [candidate] (9.032 ms) : 0, 9032
GlobalTracer [baseline] (214.457 ms) : 0, 214457
GlobalTracer [candidate] (214.976 ms) : 0, 214976
AppSec [baseline] (32.193 ms) : 0, 32193
AppSec [candidate] (32.188 ms) : 0, 32188
Debugger [baseline] (65.829 ms) : 0, 65829
Debugger [candidate] (65.882 ms) : 0, 65882
Remote Config [baseline] (569.367 µs) : 0, 569
Remote Config [candidate] (574.471 µs) : 0, 574
Telemetry [baseline] (7.682 ms) : 0, 7682
Telemetry [candidate] (7.779 ms) : 0, 7779
Flare Poller [baseline] (3.503 ms) : 0, 3503
Flare Poller [candidate] (3.524 ms) : 0, 3524
ProfilingAgent [baseline] (94.215 ms) : 0, 94215
ProfilingAgent [candidate] (93.644 ms) : 0, 93644
Profiling [baseline] (94.779 ms) : 0, 94779
Profiling [candidate] (94.198 ms) : 0, 94198
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~0cb068786f, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057695
Total [baseline] (8.896 s) : 0, 8896090
Agent [candidate] (1.056 s) : 0, 1056457
Total [candidate] (8.842 s) : 0, 8841728
section iast
Agent [baseline] (1.237 s) : 0, 1236904
Total [baseline] (9.579 s) : 0, 9579055
Agent [candidate] (1.232 s) : 0, 1231949
Total [candidate] (9.587 s) : 0, 9587095
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~0cb068786f, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (629.379 ms) : 0, 629379
BytebuddyAgent [candidate] (628.836 ms) : 0, 628836
AgentMeter [baseline] (29.352 ms) : 0, 29352
AgentMeter [candidate] (29.238 ms) : 0, 29238
GlobalTracer [baseline] (256.715 ms) : 0, 256715
GlobalTracer [candidate] (257.046 ms) : 0, 257046
AppSec [baseline] (31.764 ms) : 0, 31764
AppSec [candidate] (31.709 ms) : 0, 31709
Debugger [baseline] (59.565 ms) : 0, 59565
Debugger [candidate] (59.427 ms) : 0, 59427
Remote Config [baseline] (589.206 µs) : 0, 589
Remote Config [candidate] (582.687 µs) : 0, 583
Telemetry [baseline] (8.074 ms) : 0, 8074
Telemetry [candidate] (8.067 ms) : 0, 8067
Flare Poller [baseline] (4.994 ms) : 0, 4994
Flare Poller [candidate] (4.246 ms) : 0, 4246
section iast
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (803.712 ms) : 0, 803712
BytebuddyAgent [candidate] (799.879 ms) : 0, 799879
AgentMeter [baseline] (11.676 ms) : 0, 11676
AgentMeter [candidate] (11.438 ms) : 0, 11438
GlobalTracer [baseline] (248.942 ms) : 0, 248942
GlobalTracer [candidate] (248.249 ms) : 0, 248249
IAST [baseline] (25.591 ms) : 0, 25591
IAST [candidate] (25.408 ms) : 0, 25408
AppSec [baseline] (26.758 ms) : 0, 26758
AppSec [candidate] (26.615 ms) : 0, 26615
Debugger [baseline] (66.298 ms) : 0, 66298
Debugger [candidate] (66.626 ms) : 0, 66626
Remote Config [baseline] (521.605 µs) : 0, 522
Remote Config [candidate] (518.503 µs) : 0, 519
Telemetry [baseline] (11.748 ms) : 0, 11748
Telemetry [candidate] (11.673 ms) : 0, 11673
Flare Poller [baseline] (4.121 ms) : 0, 4121
Flare Poller [candidate] (4.105 ms) : 0, 4105
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~0cb068786f, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section baseline
no_agent (1.174 ms) : 1162, 1185
. : milestone, 1174,
iast (3.266 ms) : 3223, 3309
. : milestone, 3266,
iast_FULL (5.939 ms) : 5879, 5999
. : milestone, 5939,
iast_GLOBAL (3.632 ms) : 3573, 3691
. : milestone, 3632,
profiling (2.229 ms) : 2208, 2251
. : milestone, 2229,
tracing (1.78 ms) : 1764, 1795
. : milestone, 1780,
section candidate
no_agent (1.176 ms) : 1164, 1187
. : milestone, 1176,
iast (3.084 ms) : 3044, 3124
. : milestone, 3084,
iast_FULL (5.909 ms) : 5849, 5969
. : milestone, 5909,
iast_GLOBAL (3.541 ms) : 3487, 3596
. : milestone, 3541,
profiling (2.194 ms) : 2174, 2214
. : milestone, 2194,
tracing (1.786 ms) : 1771, 1801
. : milestone, 1786,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~0cb068786f, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section baseline
no_agent (17.416 ms) : 17236, 17596
. : milestone, 17416,
appsec (18.456 ms) : 18270, 18642
. : milestone, 18456,
code_origins (17.732 ms) : 17554, 17909
. : milestone, 17732,
iast (17.833 ms) : 17654, 18013
. : milestone, 17833,
profiling (18.325 ms) : 18145, 18505
. : milestone, 18325,
tracing (17.586 ms) : 17411, 17761
. : milestone, 17586,
section candidate
no_agent (18.568 ms) : 18375, 18762
. : milestone, 18568,
appsec (18.49 ms) : 18300, 18679
. : milestone, 18490,
code_origins (17.859 ms) : 17680, 18039
. : milestone, 17859,
iast (17.439 ms) : 17265, 17614
. : milestone, 17439,
profiling (19.541 ms) : 19343, 19739
. : milestone, 19541,
tracing (18.632 ms) : 18448, 18816
. : milestone, 18632,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~0cb068786f, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section baseline
no_agent (14.888 s) : 14888000, 14888000
. : milestone, 14888000,
appsec (14.905 s) : 14905000, 14905000
. : milestone, 14905000,
iast (18.135 s) : 18135000, 18135000
. : milestone, 18135000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
tracing (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
section candidate
no_agent (15.553 s) : 15553000, 15553000
. : milestone, 15553000,
appsec (14.689 s) : 14689000, 14689000
. : milestone, 14689000,
iast (17.933 s) : 17933000, 17933000
. : milestone, 17933000,
iast_GLOBAL (17.871 s) : 17871000, 17871000
. : milestone, 17871000,
profiling (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
tracing (14.983 s) : 14983000, 14983000
. : milestone, 14983000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~0cb068786f, baseline=1.61.0-SNAPSHOT~1abe140bde
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.513 ms) : 2458, 2567
. : milestone, 2513,
iast (2.262 ms) : 2193, 2331
. : milestone, 2262,
iast_GLOBAL (2.297 ms) : 2228, 2367
. : milestone, 2297,
profiling (2.529 ms) : 2364, 2694
. : milestone, 2529,
tracing (2.069 ms) : 2015, 2123
. : milestone, 2069,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.79 ms) : 3565, 4015
. : milestone, 3790,
iast (2.269 ms) : 2199, 2339
. : milestone, 2269,
iast_GLOBAL (2.298 ms) : 2229, 2368
. : milestone, 2298,
profiling (2.092 ms) : 2037, 2147
. : milestone, 2092,
tracing (2.07 ms) : 2016, 2124
. : milestone, 2070,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lAccums
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.