fix: close child httpx clients in AsyncStream.aclose()#230
Draft
fix: close child httpx clients in AsyncStream.aclose()#230
Conversation
AsyncStream.aclose() only closed the main httpx client but not the cached video/chat/moderation sub-clients, each of which has its own httpx connection pool. After profiling with 50 session create+close cycles, 87 orphaned TCP connections remained. Override aclose() to close all cached child clients before closing the main client.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AsyncStream.aclose()only closes the main httpx client, but the cachedvideo,chat, andmoderationsub-clients each create their own httpx connection pool via@cached_property. When the parent is closed, these child pools remain open, leaking TCP connections.Discovered during memory leak investigation in vision-agents: after 50 session create+close cycles, 87 orphaned TCP connections remained. This fix (together with vision-agents PR #457) reduced leaked TCP connections from 87 to 5 (-94%).
Changes
aclose()inAsyncStreamto close all cached child httpx clients before closing the main client