Fixed: generateSecretKeys task no longer overwrites already-set keys#1029
Merged
jacopoc merged 1 commit intoapache:trunkfrom Mar 25, 2026
Merged
Fixed: generateSecretKeys task no longer overwrites already-set keys#1029jacopoc merged 1 commit intoapache:trunkfrom
jacopoc merged 1 commit intoapache:trunkfrom
Conversation
The task was unconditionally overwriting existing keys in framework/security/config/security.properties on every run, including when triggered as a dependency of the `test` task. Keys are now only generated when the property is missing or commented out, preserving any previously configured values.
ribafish
added a commit
to gradle/develocity-oss-projects
that referenced
this pull request
Mar 26, 2026
Upstream merged apache/ofbiz-framework#1029 making generateSecretKeys skip already-set keys. We no longer need to remove the dependsOn — just pre-populate the keys with fixed values via git hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task was unconditionally overwriting existing keys in framework/security/config/security.properties on every run, including when triggered as a dependency of the
testtask.Keys are now only generated when the property is missing or commented out, preserving any previously configured values.
Thanks to Gašper Kojek (@ribafish) for reporting the issue #1028.