Skip to content

Fix: prevent VertexAiRagRetrieval from blocking event loop#5034

Open
loic-combis wants to merge 1 commit intogoogle:mainfrom
loic-combis:main
Open

Fix: prevent VertexAiRagRetrieval from blocking event loop#5034
loic-combis wants to merge 1 commit intogoogle:mainfrom
loic-combis:main

Conversation

@loic-combis
Copy link
Copy Markdown

@loic-combis loic-combis commented Mar 28, 2026

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):
#5033

Problem:
run_async makes a synchronous gRPC call.

Solution:
Defer call to thread with asyncio.to_thread

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 28, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adk-bot adk-bot added the tools [Component] This issue is related to tools label Mar 28, 2026
@adk-bot
Copy link
Copy Markdown
Collaborator

adk-bot commented Mar 28, 2026

Response from ADK Triaging Agent

Hello @loic-combis, thank you for your contribution!

Before we can merge this PR, could you please:

  • Sign the Contributor License Agreement (CLA). It seems like the CLA check is failing.
  • Complete the "Testing Plan" section in your PR description. Please describe the tests you ran to verify your changes and include a summary of the results.

This information is necessary for the reviewers to proceed with the review. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools [Component] This issue is related to tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VertexAiRagRetrieval.run_async() blocks the event loop with synchronous gRPC call

2 participants