Skip to content

Update for trusted publishing#35

Merged
delucis merged 3 commits intomainfrom
chris/trusted-publishing
Nov 18, 2025
Merged

Update for trusted publishing#35
delucis merged 3 commits intomainfrom
chris/trusted-publishing

Conversation

@delucis
Copy link
Member

@delucis delucis commented Nov 17, 2025

This PR:

  • Updates the pnpm version — this repo was on v7 (!)
  • Updates the publishing workflow to work with OIDC trusted publishing
  • Fixes a type error (showed up because Typescript was updated 5.2.2 => 5.9.3 when I updated pnpm and recreated the lock file)

Todo:

  • Update https://www.npmjs.com/package/@astrojs/cli-kit settings to point to ci.yml in withastro/cli-kit
  • Add a changeset? I like doing this to ensure we go through the full publishing flow and verify things are working (especially for a package like this we publish rarely), but I know @matthewp doesn’t agree.

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2025

⚠️ No Changeset found

Latest commit: 6c43750

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@delucis delucis merged commit 277224f into main Nov 18, 2025
1 check passed
@delucis delucis deleted the chris/trusted-publishing branch November 18, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants